Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: Source/core/dom/DOMArrayBuffer.h

Issue 717873005: Make DOMArrayBuffer()::byteLength() return unsigned int to match the type of its backing data. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DOMArrayBuffer_h 5 #ifndef DOMArrayBuffer_h
6 #define DOMArrayBuffer_h 6 #define DOMArrayBuffer_h
7 7
8 #include "bindings/core/v8/ScriptWrappable.h" 8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "wtf/ArrayBuffer.h" 9 #include "wtf/ArrayBuffer.h"
10 #include "wtf/RefCounted.h" 10 #include "wtf/RefCounted.h"
(...skipping 20 matching lines...) Expand all
31 static PassRefPtr<DOMArrayBuffer> create(WTF::ArrayBufferContents& contents) 31 static PassRefPtr<DOMArrayBuffer> create(WTF::ArrayBufferContents& contents)
32 { 32 {
33 return adoptRef(new DOMArrayBuffer(WTF::ArrayBuffer::create(contents))); 33 return adoptRef(new DOMArrayBuffer(WTF::ArrayBuffer::create(contents)));
34 } 34 }
35 35
36 const WTF::ArrayBuffer* buffer() const { return m_buffer.get(); } 36 const WTF::ArrayBuffer* buffer() const { return m_buffer.get(); }
37 WTF::ArrayBuffer* buffer() { return m_buffer.get(); } 37 WTF::ArrayBuffer* buffer() { return m_buffer.get(); }
38 38
39 const void* data() const { return buffer()->data(); } 39 const void* data() const { return buffer()->data(); }
40 void* data() { return buffer()->data(); } 40 void* data() { return buffer()->data(); }
41 unsigned long byteLength() const { return buffer()->byteLength(); } 41 unsigned byteLength() const { return buffer()->byteLength(); }
42 PassRefPtr<DOMArrayBuffer> slice(int begin, int end) const 42 PassRefPtr<DOMArrayBuffer> slice(int begin, int end) const
43 { 43 {
44 return create(buffer()->slice(begin, end)); 44 return create(buffer()->slice(begin, end));
45 } 45 }
46 PassRefPtr<DOMArrayBuffer> slice(int begin) const 46 PassRefPtr<DOMArrayBuffer> slice(int begin) const
47 { 47 {
48 return create(buffer()->slice(begin)); 48 return create(buffer()->slice(begin));
49 } 49 }
50 bool transfer(WTF::ArrayBufferContents& result) { return buffer()->transfer( result); } 50 bool transfer(WTF::ArrayBufferContents& result) { return buffer()->transfer( result); }
51 bool isNeutered() { return buffer()->isNeutered(); } 51 bool isNeutered() { return buffer()->isNeutered(); }
52 52
53 virtual v8::Handle<v8::Object> wrap(v8::Handle<v8::Object> creationContext, v8::Isolate*) override; 53 virtual v8::Handle<v8::Object> wrap(v8::Handle<v8::Object> creationContext, v8::Isolate*) override;
54 virtual v8::Handle<v8::Object> associateWithWrapper(const WrapperTypeInfo*, v8::Handle<v8::Object> wrapper, v8::Isolate*) override; 54 virtual v8::Handle<v8::Object> associateWithWrapper(const WrapperTypeInfo*, v8::Handle<v8::Object> wrapper, v8::Isolate*) override;
55 55
56 private: 56 private:
57 explicit DOMArrayBuffer(PassRefPtr<WTF::ArrayBuffer> buffer) 57 explicit DOMArrayBuffer(PassRefPtr<WTF::ArrayBuffer> buffer)
58 : m_buffer(buffer) 58 : m_buffer(buffer)
59 { 59 {
60 ASSERT(m_buffer); 60 ASSERT(m_buffer);
61 } 61 }
62 62
63 RefPtr<WTF::ArrayBuffer> m_buffer; 63 RefPtr<WTF::ArrayBuffer> m_buffer;
64 }; 64 };
65 65
66 } // namespace blink 66 } // namespace blink
67 67
68 #endif // DOMArrayBuffer_h 68 #endif // DOMArrayBuffer_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698