Clean up htmlediting

Clean up htmlediting

Clean up htmlediting by removing unused functions, making
functions static that are only used in htmlediting.cpp and
prefering const reference parameters to pointers to avoid
null checks.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186239

[rwlbuis, 2014-11-10 22:21:03]

rob.buis@samsung.com changed reviewers:
+ yosin@google.com

[rwlbuis, 2014-11-10 22:21:04]

PTAL

[rwlbuis, 2014-11-19 17:46:56]

On 2014/11/10 22:21:04, rwlbuis wrote:
> PTAL

ping

[rwlbuis, 2014-11-26 22:25:13]

On 2014/11/19 17:46:56, rwlbuis wrote:
> On 2014/11/10 22:21:04, rwlbuis wrote:
> > PTAL
> 
> ping

ping :)

[rwlbuis, 2014-11-26 22:25:59]

rob.buis@samsung.com changed reviewers:
+ yosin@chromium.org

[rwlbuis, 2014-11-26 22:26:22]

On 2014/11/26 22:25:13, rwlbuis wrote:
> On 2014/11/19 17:46:56, rwlbuis wrote:
> > On 2014/11/10 22:21:04, rwlbuis wrote:
> > > PTAL
> > 
> > ping
> 
> ping :)

Nm, probably used the wrong address :(

[yosin_UTC9, 2014-11-27 01:04:19]

yosin@chromium.org changed reviewers:
+ yutak@chromium.org
- yosin@google.com

[yosin_UTC9, 2014-11-27 01:04:19]

LGTM

+yutak@ for OWNERS review.

[Yuta Kitamura, 2014-11-27 08:38:39]

LGTM with style nitpick

https://codereview.chromium.org/717603002/diff/1/Source/core/editing/htmledit...
File Source/core/editing/htmlediting.cpp (right):

https://codereview.chromium.org/717603002/diff/1/Source/core/editing/htmledit...
Source/core/editing/htmlediting.cpp:883: bool isNodeRendered(const Node &node)
Plaese attach "&" to the type name, not the argument name.
The original code got the style wrong.

[rwlbuis, 2014-12-01 13:33:46]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-12-01 13:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/717603002/20001

[commit-bot: I haz the power, 2014-12-01 14:43:05]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186239