Source/core/editing/ReplaceSelectionCommand.cpp - Issue 717603002: Clean up htmlediting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 717603002: Clean up htmlediting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 1a18a3cb58761e01c8fc411ae96416239a045975..34dba96ab54a2c47d9a3016a205a7b3ca3916927 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -286,7 +286,7 @@ void ReplacementFragment::removeUnrenderedNodes(ContainerNode* holder)

WillBeHeapVector<RefPtrWillBeMember<Node>> unrendered;

for (Node& node : NodeTraversal::descendantsOf(*holder)) {

- if (!isNodeRendered(&node) && !isTableStructureNode(&node))

+ if (!isNodeRendered(node) && !isTableStructureNode(&node))

unrendered.append(&node);

}

« no previous file with comments | « Source/core/editing/BreakBlockquoteCommand.cpp ('k') | Source/core/editing/htmlediting.h » ('j') | no next file with comments »