Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 717373002: Use uint16 for port numbers, content/ edition (Closed)

Created:
6 years, 1 month ago by Peter Kasting
Modified:
6 years, 1 month ago
Reviewers:
davidben
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use uint16 for port numbers, content/ edition This is a piece of a larger CL, split up to avoid overwhelming reviewers. The entire CL can be viewed at https://codereview.chromium.org/655063002/ . The intent is to get each piece reviewed separately, then finally land the large CL after all parts have been approved. BUG=81439 TEST=none

Patch Set 1 #

Patch Set 2 : Self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -40 lines) Patch
M content/browser/devtools/devtools_http_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_http_handler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/tethering_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/tethering_handler.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_test_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_socket_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/devtools_http_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/socket_permission_request.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Peter Kasting
This is not an independent CL; please see the description for a link to the ...
6 years, 1 month ago (2014-11-12 23:54:20 UTC) #2
davidben
6 years, 1 month ago (2014-11-13 19:17:38 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698