content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc - Issue 717373002: Use uint16 for port numbers, content/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

Issue 717373002: Use uint16 for port numbers, content/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self-review Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_tcp_socket.cc ('k') | content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

index 38248f423413940c40078ddfecff6501071ebb09..459aa918fb8e4dcac90e6e5b4763b97d612027f6 100644

--- a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

@@ -510,7 +510,7 @@ void PepperTCPSocketMessageFilter::DoBind(

int pp_result = PP_OK;

do {

net::IPAddressNumber address;

- int port;

+ uint16 port;

if (!NetAddressPrivateImpl::NetAddressToIPEndPoint(

net_addr, &address, &port)) {

pp_result = PP_ERROR_ADDRESS_INVALID;

@@ -600,7 +600,7 @@ void PepperTCPSocketMessageFilter::DoConnectWithNetAddress(

state_.SetPendingTransition(TCPSocketState::CONNECT);

net::IPAddressNumber address;

- int port;

+ uint16 port;

if (!NetAddressPrivateImpl::NetAddressToIPEndPoint(

net_addr, &address, &port)) {

state_.CompletePendingTransition(false);