Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review update Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index 7e38a3efd8e6f8a411de0fcc08fb688bc54b7b34..5272b8da7a2423a65567f9fbf35000ef899b7bb3 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -636,7 +636,8 @@ void ServiceWorkerDispatcher::SetReadyRegistration(
void ServiceWorkerDispatcher::OnSetControllerServiceWorker(
int thread_id,
int provider_id,
- const ServiceWorkerObjectInfo& info) {
+ const ServiceWorkerObjectInfo& info,
+ bool should_notify_controllerchange) {
TRACE_EVENT2("ServiceWorker",
"ServiceWorkerDispatcher::OnSetControllerServiceWorker",
"Thread ID", thread_id,
@@ -651,7 +652,8 @@ void ServiceWorkerDispatcher::OnSetControllerServiceWorker(
ScriptClientMap::iterator found = script_clients_.find(provider_id);
if (found != script_clients_.end()) {
// Populate the .controller field with the new worker object.
- found->second->setController(GetServiceWorker(info, false));
+ found->second->setController(GetServiceWorker(info, false),
+ should_notify_controllerchange);
}
}

Powered by Google App Engine
This is Rietveld 408576698