content/child/service_worker/service_worker_message_filter.cc - Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_message_filter.cc

Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review update Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_registration.cc ('K') | « content/child/service_worker/service_worker_message_filter.h ('k') | content/child/service_worker/web_service_worker_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_message_filter.cc

diff --git a/content/child/service_worker/service_worker_message_filter.cc b/content/child/service_worker/service_worker_message_filter.cc

index 72cf320084a61f53dc3d060b001f7dc08d7f3feb..9b3cd56918423596ee321337f14294bf640f53f2 100644

--- a/content/child/service_worker/service_worker_message_filter.cc

+++ b/content/child/service_worker/service_worker_message_filter.cc

@@ -111,7 +111,8 @@ void ServiceWorkerMessageFilter::OnStaleSetVersionAttributes(

void ServiceWorkerMessageFilter::OnStaleSetControllerServiceWorker(

int thread_id,

int provider_id,

- const ServiceWorkerObjectInfo& info) {

+ const ServiceWorkerObjectInfo& info,

+ bool should_notify_controllerchange) {

dcheng 2014/12/04 00:17:09 Why is this bool unused?

xiang 2014/12/04 07:51:37 This method is to handle stale message from browse

SendServiceWorkerObjectDestroyed(thread_safe_sender_.get(), info.handle_id);

}