content/renderer/service_worker/embedded_worker_context_client.h - Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_context_client.h

Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & add should_notify_controllerchange Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/service_worker/web_service_worker_provider_impl.cc ('K') | « content/common/service_worker/service_worker_messages.h ('k') | content/renderer/service_worker/embedded_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_context_client.h

diff --git a/content/renderer/service_worker/embedded_worker_context_client.h b/content/renderer/service_worker/embedded_worker_context_client.h

index b8e02505ced0724caf2126ab2a875526efee77b8..3dcadde326fc1e462cf2d73e86cb802f53fa6610 100644

--- a/content/renderer/service_worker/embedded_worker_context_client.h

+++ b/content/renderer/service_worker/embedded_worker_context_client.h

@@ -12,6 +12,7 @@

#include "ipc/ipc_listener.h"

#include "third_party/WebKit/public/platform/WebServiceWorkerClientsInfo.h"

#include "third_party/WebKit/public/platform/WebServiceWorkerEventResult.h"

+#include "third_party/WebKit/public/platform/WebServiceWorkerSkipWaitingCallbacks.h"

#include "third_party/WebKit/public/platform/WebURL.h"

#include "third_party/WebKit/public/web/WebServiceWorkerContextClient.h"

#include "url/gurl.h"

@@ -100,6 +101,8 @@ class EmbeddedWorkerContextClient

int client_id,

const blink::WebString& message,

blink::WebMessagePortChannelArray* channels);

+ virtual void skipWaiting(

+ blink::WebServiceWorkerSkipWaitingCallbacks* callbacks);

// TODO: Implement DevTools related method overrides.