content/child/service_worker/web_service_worker_provider_impl.cc - Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_provider_impl.cc

Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & add should_notify_controllerchange Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_registration.cc ('K') | « content/child/service_worker/service_worker_message_filter.cc ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_provider_impl.cc

diff --git a/content/child/service_worker/web_service_worker_provider_impl.cc b/content/child/service_worker/web_service_worker_provider_impl.cc

index ef46bf8cc1932af5cc4730e21a5d1f4cc84ba648..c689b8afa1d3849c54559cc78975360c328d2e18 100644

--- a/content/child/service_worker/web_service_worker_provider_impl.cc

+++ b/content/child/service_worker/web_service_worker_provider_impl.cc

@@ -75,7 +75,7 @@ void WebServiceWorkerProviderImpl::setClient(

if (context_->controller_handle_id() != kInvalidServiceWorkerHandleId) {

client->setController(GetDispatcher()->GetServiceWorker(

- context_->controller()->info(), false));

+ context_->controller()->info(), false), false);

falken 2014/12/01 02:29:59 nit: add /* shouldNotifyControllerChange */ next t

xiang 2014/12/01 07:20:07 Done.

}