content/child/service_worker/service_worker_dispatcher.h - Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_dispatcher.h

Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & add should_notify_controllerchange Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_registration.cc ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/child/service_worker/service_worker_dispatcher.cc » ('j') | content/child/service_worker/web_service_worker_provider_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_dispatcher.h

diff --git a/content/child/service_worker/service_worker_dispatcher.h b/content/child/service_worker/service_worker_dispatcher.h

index 2d01452fa6952bafa18493154c2faf94ee3b5127..40eb8c36306104cafcccd4e1722821bf3d4d7763 100644

--- a/content/child/service_worker/service_worker_dispatcher.h

+++ b/content/child/service_worker/service_worker_dispatcher.h

@@ -191,7 +191,8 @@ class ServiceWorkerDispatcher : public WorkerTaskRunner::Observer {

const ServiceWorkerRegistrationObjectInfo& info);

void OnSetControllerServiceWorker(int thread_id,

int provider_id,

- const ServiceWorkerObjectInfo& info);

+ const ServiceWorkerObjectInfo& info,

+ bool should_notify_controllerchange);

void OnPostMessage(int thread_id,

int provider_id,

const base::string16& message,