content/browser/service_worker/service_worker_registration.h - Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.h

Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & add should_notify_controllerchange Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_provider_host.cc ('K') | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_registration.cc » ('j') | content/browser/service_worker/service_worker_registration.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.h

diff --git a/content/browser/service_worker/service_worker_registration.h b/content/browser/service_worker/service_worker_registration.h

index b386eecfad3fa265444694eb99c850339b07ebc3..9d7fef5e5f9b6dd3294a94d3bf2c37502e54ee07 100644

--- a/content/browser/service_worker/service_worker_registration.h

+++ b/content/browser/service_worker/service_worker_registration.h

@@ -41,6 +41,7 @@ class CONTENT_EXPORT ServiceWorkerRegistration

ServiceWorkerRegistration* registration) {}

virtual void OnUpdateFound(

ServiceWorkerRegistration* registration) {}

+ virtual void OnSkippedWaiting(ServiceWorkerRegistration* registation) {}

};

ServiceWorkerRegistration(const GURL& pattern,

@@ -99,7 +100,8 @@ class CONTENT_EXPORT ServiceWorkerRegistration

// Triggers the [[Activate]] algorithm when the currently active version

// has no controllees. If there are no controllees at the time the method

- // is called, activation is initiated immediately.

+ // is called or when version's skip waiting flag is set, activation is

+ // initiated immediately.

void ActivateWaitingVersionWhenReady();

// Triggers the [[ClearRegistration]] algorithm when the currently