Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 717353004: ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase & add should_notify_controllerchange Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index e16454558e0ec9cc46862b3110a811dcf3bfca6f..3fd9dc03813b12222cdb4965c9e08c1a4fd9a0a7 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -55,6 +55,14 @@ void ServiceWorkerProviderHost::OnRegistrationFailed(
DisassociateRegistration();
}
+void ServiceWorkerProviderHost::OnSkippedWaiting(
+ ServiceWorkerRegistration* registration) {
+ DCHECK_EQ(associated_registration_.get(), registration);
+ ServiceWorkerVersion* active_version = registration->active_version();
+ DCHECK_EQ(active_version->status(), ServiceWorkerVersion::ACTIVATING);
+ SetControllerVersionAttribute(active_version);
+}
+
void ServiceWorkerProviderHost::SetDocumentUrl(const GURL& url) {
DCHECK(!url.has_ref());
document_url_ = url;
@@ -79,8 +87,13 @@ void ServiceWorkerProviderHost::SetControllerVersionAttribute(
if (!dispatcher_host_)
return; // Could be NULL in some tests.
+ bool should_notify_controllerchange = false;
+ if (previous_version.get() && version && version->skip_waiting())
+ should_notify_controllerchange = true;
falken 2014/12/01 02:29:59 nit: bool should_notify_controllerchange = previou
xiang 2014/12/01 07:20:07 Done.
+
dispatcher_host_->Send(new ServiceWorkerMsg_SetControllerServiceWorker(
- kDocumentMainThreadId, provider_id(), CreateHandleAndPass(version)));
+ kDocumentMainThreadId, provider_id(), CreateHandleAndPass(version),
+ should_notify_controllerchange));
}
bool ServiceWorkerProviderHost::SetHostedVersionId(int64 version_id) {

Powered by Google App Engine
This is Rietveld 408576698