Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 717273002: Implement the ServiceWorkerRegistration.showNotification() method. (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Implement the ServiceWorkerRegistration.showNotification() method. This patch implements the showNotification() method by extending the ServiceWorkerRegistration object, and calling through to the Platform for requesting display of a persistent notification. BUG=432527 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185326

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : actually rebase the right patch #

Patch Set 4 : adds a test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -4 lines) Patch
A LayoutTests/http/tests/notifications/resources/empty-worker.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-show-notification.html View 1 2 3 1 chunk +31 lines, -0 lines 1 comment Download
M Source/modules/modules.gypi View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A Source/modules/notifications/ServiceWorkerRegistrationNotifications.h View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A + Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl View 1 2 3 1 chunk +3 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/717273002/diff/60001/LayoutTests/http/tests/notifications/serviceworkerregistration-show-notification.html File LayoutTests/http/tests/notifications/serviceworkerregistration-show-notification.html (right): https://codereview.chromium.org/717273002/diff/60001/LayoutTests/http/tests/notifications/serviceworkerregistration-show-notification.html#newcode15 LayoutTests/http/tests/notifications/serviceworkerregistration-show-notification.html:15: worker_url = 'resources/empty-worker.js'; nit: you might want that ...
6 years, 1 month ago (2014-11-13 21:08:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717273002/60001
6 years, 1 month ago (2014-11-13 21:09:30 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 22:55:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 185326

Powered by Google App Engine
This is Rietveld 408576698