Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl - Issue 717273002: Implement the ServiceWorkerRegistration.showNotification() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl

Issue 717273002: Implement the ServiceWorkerRegistration.showNotification() method. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: adds a test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/notifications/serviceworkerregistration-show-notification.html ('K') | « Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl

diff --git a/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl

similarity index 53%

copy from Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

copy to Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl

index b2a61e5dbf84558ee4342060c0b1121f1476d710..c035165a14cbd559bbbc52218fc1d261b1d3e880 100644

--- a/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

+++ b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl

@@ -5,8 +5,7 @@

// https://notifications.spec.whatwg.org/#service-worker-api

[

- RuntimeEnabled=ServiceWorkerNotifications,

-] partial interface ServiceWorkerGlobalScope {

- attribute EventHandler onnotificationclick;

- attribute EventHandler onnotificationerror;

+ RuntimeEnabled=ServiceWorkerNotifications

+] partial interface ServiceWorkerRegistration {

+ [CallWith=ScriptState] Promise showNotification(DOMString title, optional NotificationOptions options);

mlamouri (slow - plz ping) 2014/11/13 21:08:02 nit: maybe re-upload with no similarity?

};