Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: extensions/browser/api/socket/tcp_socket.h

Issue 717263003: Use uint16 for port numbers, extensions/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/socket/tcp_socket.h
diff --git a/extensions/browser/api/socket/tcp_socket.h b/extensions/browser/api/socket/tcp_socket.h
index 3eeeaaead7d4e8bcf7650816bba8d2b9645f990d..396eff7960d22dac1937dca3294f8ec46d55a97e 100644
--- a/extensions/browser/api/socket/tcp_socket.h
+++ b/extensions/browser/api/socket/tcp_socket.h
@@ -30,21 +30,21 @@ class TCPSocket : public Socket {
~TCPSocket() override;
void Connect(const std::string& address,
- int port,
+ uint16 port,
const CompletionCallback& callback) override;
void Disconnect() override;
- int Bind(const std::string& address, int port) override;
+ int Bind(const std::string& address, uint16 port) override;
void Read(int count, const ReadCompletionCallback& callback) override;
void RecvFrom(int count, const RecvFromCompletionCallback& callback) override;
void SendTo(scoped_refptr<net::IOBuffer> io_buffer,
int byte_count,
const std::string& address,
- int port,
+ uint16 port,
const CompletionCallback& callback) override;
bool SetKeepAlive(bool enable, int delay) override;
bool SetNoDelay(bool no_delay) override;
int Listen(const std::string& address,
- int port,
+ uint16 port,
int backlog,
std::string* error_msg) override;
void Accept(const AcceptCompletionCallback& callback) override;

Powered by Google App Engine
This is Rietveld 408576698