Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: extensions/browser/api/socket/tcp_socket.cc

Issue 717263003: Use uint16 for port numbers, extensions/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/socket/tcp_socket.cc
diff --git a/extensions/browser/api/socket/tcp_socket.cc b/extensions/browser/api/socket/tcp_socket.cc
index 28ce6df8ac0539f31a1c1b8047df4ef16faf8464..4863602a18b9eb2ec7fcda79e09076db4bc1871e 100644
--- a/extensions/browser/api/socket/tcp_socket.cc
+++ b/extensions/browser/api/socket/tcp_socket.cc
@@ -78,7 +78,7 @@ TCPSocket* TCPSocket::CreateServerSocketForTesting(
TCPSocket::~TCPSocket() { Disconnect(); }
void TCPSocket::Connect(const std::string& address,
- int port,
+ uint16 port,
const CompletionCallback& callback) {
DCHECK(!callback.is_null());
@@ -124,7 +124,7 @@ void TCPSocket::Disconnect() {
accept_socket_.reset(NULL);
}
-int TCPSocket::Bind(const std::string& address, int port) {
+int TCPSocket::Bind(const std::string& address, uint16 port) {
return net::ERR_FAILED;
}
@@ -171,7 +171,7 @@ void TCPSocket::RecvFrom(int count,
void TCPSocket::SendTo(scoped_refptr<net::IOBuffer> io_buffer,
int byte_count,
const std::string& address,
- int port,
+ uint16 port,
const CompletionCallback& callback) {
callback.Run(net::ERR_FAILED);
}
@@ -189,7 +189,7 @@ bool TCPSocket::SetNoDelay(bool no_delay) {
}
int TCPSocket::Listen(const std::string& address,
- int port,
+ uint16 port,
int backlog,
std::string* error_msg) {
if (socket_mode_ == CLIENT) {

Powered by Google App Engine
This is Rietveld 408576698