Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 717243003: Revert of Roll gyp 1994->1998. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel, scottmg
CC:
chromium-reviews, Shezan Baig (Bloomberg), Sébastien Marchand
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@1_roll
Project:
chromium
Visibility:
Public.

Description

Revert of Roll gyp 1994->1998. (patchset #3 id:40001 of https://codereview.chromium.org/705793002/) Reason for revert: Caused http://crbug.com/432483 Original issue's description: > Roll gyp 1994->1998. > > $ git log -4 --format="%ad %s" --date=short > 2014-11-05 Set ZERO_AR_DATE=1 when running libtool. > 2014-11-04 msvs: Fix rule dependencies for VS2013 > 2014-10-30 Switch to 2013 now that it's what's on the bots > 2014-10-28 Add indentation offset guess for gyp emacs mode. > > R=thakis@chromium.org,scottmg@chromium.org > BUG=330262 > > Committed: https://crrev.com/050a43d0b4a5da906b1484d63dd3d4aa1f4952d0 > Cr-Commit-Position: refs/heads/master@{#302887} TBR=scottmg@chromium.org,maruel@chromium.org NOTREECHECKS=true NOTRY=true BUG=330262 Committed: https://crrev.com/fc35df0d4e8e32cb02206fa6640a327f4867edb2 Cr-Commit-Position: refs/heads/master@{#303854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Roll gyp 1994->1998.
6 years, 1 month ago (2014-11-12 18:25:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717243003/1
6 years, 1 month ago (2014-11-12 18:26:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 18:27:06 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 18:27:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc35df0d4e8e32cb02206fa6640a327f4867edb2
Cr-Commit-Position: refs/heads/master@{#303854}

Powered by Google App Engine
This is Rietveld 408576698