Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 705793002: Roll gyp 1994->1998. (Closed)

Created:
6 years, 1 month ago by M-A Ruel
Modified:
6 years, 1 month ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews, Shezan Baig (Bloomberg), Sébastien Marchand
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@1_roll
Project:
chromium
Visibility:
Public.

Description

Roll gyp 1994->1998. $ git log -4 --format="%ad %s" --date=short 2014-11-05 Set ZERO_AR_DATE=1 when running libtool. 2014-11-04 msvs: Fix rule dependencies for VS2013 2014-10-30 Switch to 2013 now that it's what's on the bots 2014-10-28 Add indentation offset guess for gyp emacs mode. R=thakis@chromium.org,scottmg@chromium.org BUG=330262 Committed: https://crrev.com/050a43d0b4a5da906b1484d63dd3d4aa1f4952d0 Cr-Commit-Position: refs/heads/master@{#302887}

Patch Set 1 #

Patch Set 2 : Oops wrong hash #

Patch Set 3 : I had based this CL on another branch by accident, which broke the try jobs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
M-A Ruel
6 years, 1 month ago (2014-11-05 20:06:11 UTC) #2
Nico
lgtm
6 years, 1 month ago (2014-11-05 20:11:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705793002/40001
6 years, 1 month ago (2014-11-05 20:16:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/9049)
6 years, 1 month ago (2014-11-05 21:33:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705793002/40001
6 years, 1 month ago (2014-11-05 21:42:42 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 22:23:59 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/050a43d0b4a5da906b1484d63dd3d4aa1f4952d0 Cr-Commit-Position: refs/heads/master@{#302887}
6 years, 1 month ago (2014-11-05 22:24:44 UTC) #11
Nico
6 years, 1 month ago (2014-11-12 18:25:25 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/717243003/ by thakis@chromium.org.

The reason for reverting is: Caused http://crbug.com/432483.

Powered by Google App Engine
This is Rietveld 408576698