Browser watcher end-end-to-end .

components/browser_watcher/watcher_metrics_provider_win.h

Index: components/browser_watcher/watcher_metrics_provider_win.h
diff --git a/components/browser_watcher/watcher_metrics_provider_win.h b/components/browser_watcher/watcher_metrics_provider_win.h
new file mode 100644
index 0000000000000000000000000000000000000000..fee1d844ca29aeebb2648c590765138b079552ac
--- /dev/null
+++ b/components/browser_watcher/watcher_metrics_provider_win.h
@@ -0,0 +1,34 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_
+#define COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_
+
+#include <windows.h>

[erikwright (departed), 2014/11/14 19:46:10]

not used

[Sigurður Ásgeirsson, 2014/11/17 15:26:58]

Done.

+
+#include "base/strings/string16.h"
+#include "components/metrics/metrics_provider.h"
+
+namespace browser_watcher {
+
+// Provides stability data captured by the Chrome Watcher, namely the browser
+// process exit codes.
+class WatcherMetricsProviderWin : public metrics::MetricsProvider {
+ public:
+  explicit WatcherMetricsProviderWin(const base::string16& registry_path);
+

[erikwright (departed), 2014/11/14 19:46:09]

An explicit destructor should be supplied.

[Sigurður Ásgeirsson, 2014/11/17 15:26:58]

Sure, why?

+  virtual void ProvideStabilityMetrics(

[erikwright (departed), 2014/11/14 19:46:10]

// metrics::MetricsProvider implementation

[Sigurður Ásgeirsson, 2014/11/17 15:26:58]

Done.

+      metrics::SystemProfileProto* system_profile_proto) override;
+
+  static const char kBrowserExitCodeHistogramName[];

[erikwright (departed), 2014/11/14 19:46:10]

According to
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Declaration_O...
constants go before methods (including constructor).

[Sigurður Ásgeirsson, 2014/11/17 15:26:58]

Done.

+
+ private:
+  base::string16 registry_path_;
+
+  DISALLOW_COPY_AND_ASSIGN(WatcherMetricsProviderWin);

[erikwright (departed), 2014/11/14 19:46:10]

IWYU base/macros.h

[Sigurður Ásgeirsson, 2014/11/17 15:26:58]

Done.

+};
+
+}  // namespace browser_watcher
+
+#endif  // COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_