OLD | NEW |
---|---|
(Empty) | |
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #ifndef COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_ | |
6 #define COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_ | |
7 | |
8 #include <windows.h> | |
erikwright (departed)
2014/11/14 19:46:10
not used
Sigurður Ásgeirsson
2014/11/17 15:26:58
Done.
| |
9 | |
10 #include "base/strings/string16.h" | |
11 #include "components/metrics/metrics_provider.h" | |
12 | |
13 namespace browser_watcher { | |
14 | |
15 // Provides stability data captured by the Chrome Watcher, namely the browser | |
16 // process exit codes. | |
17 class WatcherMetricsProviderWin : public metrics::MetricsProvider { | |
18 public: | |
19 explicit WatcherMetricsProviderWin(const base::string16& registry_path); | |
20 | |
erikwright (departed)
2014/11/14 19:46:09
An explicit destructor should be supplied.
Sigurður Ásgeirsson
2014/11/17 15:26:58
Sure, why?
| |
21 virtual void ProvideStabilityMetrics( | |
erikwright (departed)
2014/11/14 19:46:10
// metrics::MetricsProvider implementation
Sigurður Ásgeirsson
2014/11/17 15:26:58
Done.
| |
22 metrics::SystemProfileProto* system_profile_proto) override; | |
23 | |
24 static const char kBrowserExitCodeHistogramName[]; | |
erikwright (departed)
2014/11/14 19:46:10
According to http://google-styleguide.googlecode.c
Sigurður Ásgeirsson
2014/11/17 15:26:58
Done.
| |
25 | |
26 private: | |
27 base::string16 registry_path_; | |
28 | |
29 DISALLOW_COPY_AND_ASSIGN(WatcherMetricsProviderWin); | |
erikwright (departed)
2014/11/14 19:46:10
IWYU base/macros.h
Sigurður Ásgeirsson
2014/11/17 15:26:58
Done.
| |
30 }; | |
31 | |
32 } // namespace browser_watcher | |
33 | |
34 #endif // COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_ | |
OLD | NEW |