Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 7172016: Add linux3 build support to chromium (base repository) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by google
Modified:
6 years ago
CC:
chromium-reviews, finnur+watch_chromium.org, Nirnimesh, John Grabowski, Erik does not do reviews, kkania, Aaron Boodman, anantha, pam+watch_chromium.org, arv (Not doing code reviews), dyu1, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

Add support for Linux kernels >=3.0-rc1 in Python related build files by: - replacing occurences of sys.platform == 'linux2' with sys.platform.startswith('linux') - congregating occurences of sys.platform in ('linux[X]', 'linuxY', ...) to sys.platform.startswith('linux') - adding the key 'linux3' to all relevant lookup dicts BUG=85845 TEST=Try building chromium on Linux >=3.0-r1 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89354

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/build/build.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto_utils.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/chromedriver_launcher.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/webdriver/run_webdriver_tests.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/process_dumps_linux.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/code_coverage/coverage_posix.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/code_coverage/process_coverage.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/coverity/coverity.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/heapcheck/chrome_tests.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/python/google/platform_utils.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/swig/swig.py View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (0 generated)
Paweł Hajdan Jr.
+sky for ui/ OWNERS approval +tony for grit comments LGTM, please add yourself to the ...
6 years ago (2011-06-15 17:07:45 UTC) #1
google_tk-webart.de
Hi Paweł, so, this is the new patch for chromium base repository, without any third-party ...
6 years ago (2011-06-15 17:07:57 UTC) #2
tony
Can you wait until I've landed http://codereview.chromium.org/7181002/ then sync to tip of tree and re-upload ...
6 years ago (2011-06-15 23:23:52 UTC) #3
google_tk-webart.de
> Can you wait until I've landed http://codereview.chromium.org/7181002/ then sync > to tip of tree ...
6 years ago (2011-06-16 04:02:12 UTC) #4
google_tk-webart.de
On 2011/06/16 04:02:12, torsti76 wrote: > > Can you wait until I've landed http://codereview.chromium.org/7181002/ then ...
6 years ago (2011-06-16 09:26:55 UTC) #5
Paweł Hajdan Jr.
LGTM - now we shouldn't need any OWNERS checks and there are no grit changes, ...
6 years ago (2011-06-16 10:09:20 UTC) #6
commit-bot: I haz the power
No LGTM from valid reviewers yet.
6 years ago (2011-06-16 10:09:37 UTC) #7
commit-bot: I haz the power
No LGTM from valid reviewers yet.
6 years ago (2011-06-16 16:14:55 UTC) #8
google_tk-webart.de
On 2011/06/16 10:09:37, I haz the power (commit-bot) wrote: > No LGTM from valid reviewers ...
6 years ago (2011-06-16 16:15:49 UTC) #9
M-A Ruel
lgtm
6 years ago (2011-06-16 16:40:32 UTC) #10
commit-bot: I haz the power
Presubmit check for 7172016-8004 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2011-06-16 16:40:51 UTC) #11
commit-bot: I haz the power
Presubmit check for 7172016-8004 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2011-06-16 17:14:40 UTC) #12
tony
I will fix the license and land manually.
6 years ago (2011-06-16 17:15:28 UTC) #13
tony
6 years ago (2011-06-16 17:16:10 UTC) #14
r89354
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589