Issue 7181002: Remove references to 'linux2' from our grd files.

Issue 7181002: Remove references to 'linux2' from our grd files. (Closed)

Created:
9 years, 6 months ago by tony

Modified:
9 years, 6 months ago

Reviewers:
ruben, mmenke

CC:
chromium-reviews, finnur+watch_chromium.org, pam+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove references to 'linux2' from our grd files. BUG=85845 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89271

Patch Set 3 : personal_options and gfx_resources #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
M	app/resources/app_resources.grd	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/app/resources/locale_settings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_resources.grd	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/gfx_resources.grd	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tony

http://codereview.chromium.org/7181002/diff/1001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): http://codereview.chromium.org/7181002/diff/1001/chrome/app/generated_resources.grd#oldcode2418 chrome/app/generated_resources.grd:2418: <if expr="not pp_ifdef('use_titlecase') or os != 'linux2'"> AFAICT, this ...

9 years, 6 months ago (2011-06-15 23:22:51 UTC) #2

ruben

LGTM, you might also want to get two other files in this patch: chrome/browser/resources/options/personal_options.html ui/gfx/gfx_resources.grd ...

9 years, 6 months ago (2011-06-15 23:37:08 UTC) #4

tony

9 years, 6 months ago (2011-06-15 23:42:15 UTC) #5

On 2011/06/15 23:37:08, ruben wrote:
> LGTM, you might also want to get two other files in this patch:
> 
> chrome/browser/resources/options/personal_options.html
> ui/gfx/gfx_resources.grd

Good idea.  I've added those two files.

> There are some more html files in chrome/browser/resources/options/ that use
the
> same OS defines.  I think they are also processed by grit.

Yeah, there are still references to darwin and win32 that I want to clean up,
but I want to get the linux2 stuff out of the way first.  I'll fix these in a
follow up patch.

Expand Messages | Collapse Messages