Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 7169005: Merge 88595 - Revert 88545 - Revert 88470 (broke ServiceProcessStateTest.ForceShutdown on CrOS) -... (Closed)

Created:
9 years, 6 months ago by rkc
Modified:
9 years, 6 months ago
Reviewers:
rkc
CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Merge 88595 - Revert 88545 - Revert 88470 (broke ServiceProcessStateTest.ForceShutdown on CrOS) - Fix for system version unit tests in cros. Unit test the revert was to fix is still failing after the revert. Also confirmed that the failing test has nothing to do with this CL. BUG=chromium-os:15789 TEST=Ran try servers to make sure the unit test is not failing anymore, plus viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug TBR=rkc@chromium.org TBR=rkc@chromium.org Review URL: http://codereview.chromium.org/7044086 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/7044097 TBR=rkc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -26 lines) Patch
M base/sys_info_chromeos.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M base/sys_info_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/background_view.cc View 4 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/version_loader.h View 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/chromeos/version_loader.cc View 4 chunks +23 lines, -1 line 0 comments Download
M chrome/browser/resources/options/about_page.html View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/about_page_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rkc
9 years, 6 months ago (2011-06-15 01:36:22 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698