Issue 7044086: Revert 88470 (broke ServiceProcessStateTest.ForceShutdown on CrOS) - Fix for system version unit ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7044086: Revert 88470 (broke ServiceProcessStateTest.ForceShutdown on CrOS) - Fix for system version unit ... (Closed)

Created:
9 years, 6 months ago by Nico

Modified:
9 years, 6 months ago

Reviewers:
rkc

CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 88470 (broke ServiceProcessStateTest.ForceShutdown on CrOS) - Fix for system version unit tests in cros. BUG=chromium-os:15789 TEST=Ran try servers to make sure the unit test is not failing anymore, plus viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug TBR=rkc@chromium.org TBR=rkc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88545

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -72 lines)			Patch
M	base/sys_info_chromeos.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	base/sys_info_unittest.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/background_view.cc	View	4 chunks	+4 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/version_loader.h	View	3 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/chromeos/version_loader.cc	View	4 chunks	+1 line, -23 lines	0 comments	Download
M	chrome/browser/resources/options/about_page.html	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/options/about_page_handler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages