Issue 716843002: Cherrypicking revert which caused a bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 716843002: Cherrypicking revert which caused a bug. (Closed)

Created:
6 years, 1 month ago by matthewyuan

Modified:
6 years, 1 month ago

Reviewers:
felt, Ryan Sleevi, abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, mmenke

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cherrypicking revert which caused a bug. BUG=431907 Revert "Reject certificates that are valid for too long." Was: https://codereview.chromium.org/20628006 We want this change in M41, not M40. Also, it has a date math bug. A new CL to fix the bug and re-land will come soon. BUG=119211 TBR=rsleevi@chromium.org,abarth,felt Review URL: https://codereview.chromium.org/717653002 Cr-Commit-Position: refs/heads/master@{#303562} (cherry picked from commit 03ef2046664b096b28ccc753d081050a3cd117d5) Committed: https://chromium.googlesource.com/chromium/src/+/eb1c866cc26014767e795ebcc83bb952a495fe77

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+268 lines, -831 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ssl/ssl_error_info.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ssl/ssl_error_info.cc	View	4 chunks	+21 lines, -33 lines	0 comments	Download
M	content/browser/ssl/ssl_policy.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/base/net_error_list.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	net/cert/cert_status_flags.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	net/cert/cert_status_flags_list.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/cert/cert_verify_proc.h	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	net/cert/cert_verify_proc.cc	View	4 chunks	+1 line, -47 lines	0 comments	Download
M	net/cert/cert_verify_proc_unittest.cc	View	7 chunks	+20 lines, -37 lines	0 comments	Download
D	net/data/ssl/certificates/11_year_validity.pem	View	1 chunk	+0 lines, -81 lines	0 comments	Download
D	net/data/ssl/certificates/40_months_after_2015_04.pem	View	1 chunk	+0 lines, -81 lines	0 comments	Download
D	net/data/ssl/certificates/61_months_after_2012_07.pem	View	1 chunk	+0 lines, -81 lines	0 comments	Download
M	net/data/ssl/certificates/README	View	3 chunks	+4 lines, -8 lines	0 comments	Download
D	net/data/ssl/certificates/reject_intranet_hosts.pem	View	1 chunk	+0 lines, -69 lines	0 comments	Download
A	net/data/ssl/certificates/satveda.pem	View	1 chunk	+207 lines, -0 lines	0 comments	Download
D	net/data/ssl/certificates/twitter-chain.pem	View	1 chunk	+0 lines, -302 lines	0 comments	Download
M	net/data/ssl/scripts/generate-test-certs.sh	View	1 chunk	+1 line, -45 lines	0 comments	Download
M	net/test/test_certificate_data.h	View	1 chunk	+13 lines, -17 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

matthewyuan

6 years, 1 month ago (2014-11-11 17:40:27 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eb1c866cc26014767e795ebcc83bb952a495fe77.

Expand Messages | Collapse Messages