Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 717653002: Revert "Reject certificates that are valid for too long." (Closed)

Created:
6 years, 1 month ago by palmer
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Reject certificates that are valid for too long." Was: https://codereview.chromium.org/20628006 We want this change in M41, not M40. Also, it has a date math bug. A new CL to fix the bug and re-land will come soon. BUG=119211 TBR=rsleevi@chromium.org,abarth,felt Committed: https://crrev.com/03ef2046664b096b28ccc753d081050a3cd117d5 Cr-Commit-Position: refs/heads/master@{#303562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -831 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ssl/ssl_error_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_info.cc View 4 chunks +21 lines, -33 lines 0 comments Download
M content/browser/ssl/ssl_policy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/net_error_list.h View 1 chunk +1 line, -4 lines 0 comments Download
M net/cert/cert_status_flags.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/cert/cert_status_flags_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/cert_verify_proc.h View 2 chunks +0 lines, -13 lines 0 comments Download
M net/cert/cert_verify_proc.cc View 4 chunks +1 line, -47 lines 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 7 chunks +20 lines, -37 lines 0 comments Download
D net/data/ssl/certificates/11_year_validity.pem View 1 chunk +0 lines, -81 lines 0 comments Download
D net/data/ssl/certificates/40_months_after_2015_04.pem View 1 chunk +0 lines, -81 lines 0 comments Download
D net/data/ssl/certificates/61_months_after_2012_07.pem View 1 chunk +0 lines, -81 lines 0 comments Download
M net/data/ssl/certificates/README View 3 chunks +4 lines, -8 lines 0 comments Download
D net/data/ssl/certificates/reject_intranet_hosts.pem View 1 chunk +0 lines, -69 lines 0 comments Download
A net/data/ssl/certificates/satveda.pem View 1 chunk +207 lines, -0 lines 0 comments Download
D net/data/ssl/certificates/twitter-chain.pem View 1 chunk +0 lines, -302 lines 0 comments Download
M net/data/ssl/scripts/generate-test-certs.sh View 1 chunk +1 line, -45 lines 0 comments Download
M net/test/test_certificate_data.h View 1 chunk +13 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717653002/1
6 years, 1 month ago (2014-11-11 00:19:44 UTC) #2
felt
lgtm thanks chris
6 years, 1 month ago (2014-11-11 00:20:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 01:24:40 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 01:25:05 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/03ef2046664b096b28ccc753d081050a3cd117d5
Cr-Commit-Position: refs/heads/master@{#303562}

Powered by Google App Engine
This is Rietveld 408576698