android_webview/native/aw_autofill_manager_delegate.h - Issue 71683003: Have AutofillManagerDelegate supply the AutofillWebDataService to core code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_autofill_manager_delegate.h

Issue 71683003: Have AutofillManagerDelegate supply the AutofillWebDataService to core code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/aw_autofill_manager_delegate.h

diff --git a/android_webview/native/aw_autofill_manager_delegate.h b/android_webview/native/aw_autofill_manager_delegate.h

index a86343a8af6251a0739458f63a286772613cbc8d..383ab61e2678c223c3322a53bba8605205788dd1 100644

--- a/android_webview/native/aw_autofill_manager_delegate.h

+++ b/android_webview/native/aw_autofill_manager_delegate.h

@@ -58,6 +58,8 @@ class AwAutofillManagerDelegate

// AutofillManagerDelegate implementation.

virtual autofill::PersonalDataManager* GetPersonalDataManager() OVERRIDE;

+ virtual scoped_refptr<autofill::AutofillWebDataService>

+ GetDatabase() OVERRIDE;

joth 2013/11/18 19:36:53 this thread seems to suggest returning raw pointer

blundell 2013/11/19 11:17:14 Thanks. I'd prefer to keep that change separate fr

virtual PrefService* GetPrefs() OVERRIDE;

virtual void HideRequestAutocompleteDialog() OVERRIDE;

virtual void ShowAutofillSettings() OVERRIDE;

« no previous file with comments | « no previous file | android_webview/native/aw_autofill_manager_delegate.cc » ('j') | no next file with comments »