android_webview/native/aw_autofill_manager_delegate.h - Issue 71683003: Have AutofillManagerDelegate supply the AutofillWebDataService to core code.

Side by Side Diff: android_webview/native/aw_autofill_manager_delegate.h

Issue 71683003: Have AutofillManagerDelegate supply the AutofillWebDataService to core code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | android_webview/native/aw_autofill_manager_delegate.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_AUTOFILL_MANAGER_DELEGATE_H_	5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_AUTOFILL_MANAGER_DELEGATE_H_

6 #define ANDROID_WEBVIEW_BROWSER_AW_AUTOFILL_MANAGER_DELEGATE_H_	6 #define ANDROID_WEBVIEW_BROWSER_AW_AUTOFILL_MANAGER_DELEGATE_H_

7	7

8 #include <jni.h>	8 #include <jni.h>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 public content::WebContentsUserData<AwAutofillManagerDelegate> {	51 public content::WebContentsUserData<AwAutofillManagerDelegate> {

52	52

53 public:	53 public:

54 virtual ~AwAutofillManagerDelegate();	54 virtual ~AwAutofillManagerDelegate();

55	55

56 void SetSaveFormData(bool enabled);	56 void SetSaveFormData(bool enabled);

57 bool GetSaveFormData();	57 bool GetSaveFormData();

58	58

59 // AutofillManagerDelegate implementation.	59 // AutofillManagerDelegate implementation.

60 virtual autofill::PersonalDataManager* GetPersonalDataManager() OVERRIDE;	60 virtual autofill::PersonalDataManager* GetPersonalDataManager() OVERRIDE;

	61 virtual scoped_refptr<autofill::AutofillWebDataService>

	62 GetDatabase() OVERRIDE;
	joth 2013/11/18 19:36:53 this thread seems to suggest returning raw pointer this thread seems to suggest returning raw pointer is safer than returning refptr https://groups.google.com/a/chromium.org/d/topic/chromium-dev/uuaKaTzaCwE/dis... blundell 2013/11/19 11:17:14 Thanks. I'd prefer to keep that change separate fr Thanks. I'd prefer to keep that change separate from this refactoring to limit the number of moving parts. I filed crbug.com/321059. On 2013/11/18 19:36:53, joth wrote: Show quoted text > this thread seems to suggest returning raw pointer is safer than returning > refptr > https://groups.google.com/a/chromium.org/d/topic/chromium-dev/uuaKaTzaCwE/dis...
61 virtual PrefService* GetPrefs() OVERRIDE;	63 virtual PrefService* GetPrefs() OVERRIDE;

62 virtual void HideRequestAutocompleteDialog() OVERRIDE;	64 virtual void HideRequestAutocompleteDialog() OVERRIDE;

63 virtual void ShowAutofillSettings() OVERRIDE;	65 virtual void ShowAutofillSettings() OVERRIDE;

64 virtual void ConfirmSaveCreditCard(	66 virtual void ConfirmSaveCreditCard(

65 const autofill::AutofillMetrics& metric_logger,	67 const autofill::AutofillMetrics& metric_logger,

66 const base::Closure& save_card_callback) OVERRIDE;	68 const base::Closure& save_card_callback) OVERRIDE;

67 virtual void ShowRequestAutocompleteDialog(	69 virtual void ShowRequestAutocompleteDialog(

68 const autofill::FormData& form,	70 const autofill::FormData& form,

69 const GURL& source_url,	71 const GURL& source_url,

70 const base::Callback<void(const autofill::FormStructure*)>& callback)	72 const base::Callback<void(const autofill::FormStructure*)>& callback)

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
108 base::WeakPtr<autofill::AutofillPopupDelegate> delegate_;	110 base::WeakPtr<autofill::AutofillPopupDelegate> delegate_;

109	111

110 DISALLOW_COPY_AND_ASSIGN(AwAutofillManagerDelegate);	112 DISALLOW_COPY_AND_ASSIGN(AwAutofillManagerDelegate);

111 };	113 };

112	114

113 bool RegisterAwAutofillManagerDelegate(JNIEnv* env);	115 bool RegisterAwAutofillManagerDelegate(JNIEnv* env);

114	116

115 } // namespace android_webview	117 } // namespace android_webview

116	118

117 #endif // ANDROID_WEBVIEW_BROWSER_AW_AUTOFILL_MANAGER_DELEGATE_H_	119 #endif // ANDROID_WEBVIEW_BROWSER_AW_AUTOFILL_MANAGER_DELEGATE_H_

OLD	NEW