Issue 716453004: Mojo JS Bindings: revert the Mojo handle toString() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 716453004: Mojo JS Bindings: revert the Mojo handle toString() method (Closed)

Created:
6 years, 1 month ago by hansmuller

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Mojo JS Bindings: revert the Mojo handle toString() method Revert https://codereview.chromium.org/646783005 since Valgrind claims that it causes a leak. BUG=431213 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6f2aeb863662c89519a64258993dc93e940a8846

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -39 lines)			Patch
M	mojo/edk/js/handle.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	mojo/edk/js/handle.cc	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	mojo/public/js/core_unittests.js	View	2 chunks	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hansmuller

6 years, 1 month ago (2014-11-11 00:44:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f2aeb863662c89519a64258993dc93e940a8846 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages