Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: mojo/edk/js/handle.h

Issue 716453004: Mojo JS Bindings: revert the Mojo handle toString() method (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/edk/js/handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/js/handle.h
diff --git a/mojo/edk/js/handle.h b/mojo/edk/js/handle.h
index c60a3963b558120d4b94405408493d6c98d97012..200b322d44f3c9f7aa24e4dce18580fc9ceec709 100644
--- a/mojo/edk/js/handle.h
+++ b/mojo/edk/js/handle.h
@@ -8,7 +8,6 @@
#include "base/observer_list.h"
#include "gin/converter.h"
#include "gin/handle.h"
-#include "gin/object_template_builder.h"
#include "gin/wrappable.h"
#include "mojo/public/cpp/system/core.h"
@@ -27,11 +26,6 @@ class HandleWrapper : public gin::Wrappable<HandleWrapper> {
return gin::CreateHandle(isolate, new HandleWrapper(handle));
}
- std::string ToString();
-
- gin::ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate* isolate)
- override;
-
mojo::Handle get() const { return handle_.get(); }
mojo::Handle release() { return handle_.release(); }
void Close();
« no previous file with comments | « no previous file | mojo/edk/js/handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698