Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: components/devtools_bridge/rtc_configuration.h

Issue 716433003: Continue impementation SessionDependencyFactoryNative. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native-factory
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_bridge/rtc_configuration.h
diff --git a/components/devtools_bridge/rtc_configuration.h b/components/devtools_bridge/rtc_configuration.h
new file mode 100644
index 0000000000000000000000000000000000000000..230bc744e33c6e13955ae3b0e79295fe798e707c
--- /dev/null
+++ b/components/devtools_bridge/rtc_configuration.h
@@ -0,0 +1,39 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DEVTOOLS_BRIDGE_RTC_CONFIGURATION_H_
+#define COMPONENTS_DEVTOOLS_BRIDGE_RTC_CONFIGURATION_H_
+
+#import <string>
mnaganov (inactive) 2014/11/10 18:10:26 Why #import?
SeRya 2014/11/11 08:08:19 Apparently java-reflex. Fixed here and in other pl
+
+#include "base/memory/scoped_ptr.h"
+
+namespace devtools_bridge {
+
+/**
+ * WebRTC configuration for DevTools Bridge.
+ */
+class RTCConfiguration {
+ public:
+ class Impl;
+
+ RTCConfiguration() {}
+ virtual ~RTCConfiguration() {}
+
+ virtual void AddIceServer(
+ std::string const& uri,
+ std::string const& username,
+ std::string const& credential) = 0;
+
+ virtual Impl const& impl() const = 0;
mnaganov (inactive) 2014/11/10 18:10:26 Shouldn't it be "const& Impl" instead?
SeRya 2014/11/11 08:08:19 Checked in the styleguide. It requires "const Type
+
+ static scoped_ptr<RTCConfiguration> CreateInstance();
+
+ private:
mnaganov (inactive) 2014/11/10 18:10:26 Bad indentation.
SeRya 2014/11/11 08:08:19 Done.
+ DISALLOW_COPY_AND_ASSIGN(RTCConfiguration);
+};
+
+} // namespace devtools_bridge
+
+#endif // COMPONENTS_DEVTOOLS_BRIDGE_RTC_CONFIGURATION_H_

Powered by Google App Engine
This is Rietveld 408576698