Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef COMPONENTS_DEVTOOLS_BRIDGE_RTC_CONFIGURATION_H_ | |
| 6 #define COMPONENTS_DEVTOOLS_BRIDGE_RTC_CONFIGURATION_H_ | |
| 7 | |
| 8 #import <string> | |
|
mnaganov (inactive)
2014/11/10 18:10:26
Why #import?
SeRya
2014/11/11 08:08:19
Apparently java-reflex. Fixed here and in other pl
| |
| 9 | |
| 10 #include "base/memory/scoped_ptr.h" | |
| 11 | |
| 12 namespace devtools_bridge { | |
| 13 | |
| 14 /** | |
| 15 * WebRTC configuration for DevTools Bridge. | |
| 16 */ | |
| 17 class RTCConfiguration { | |
| 18 public: | |
| 19 class Impl; | |
| 20 | |
| 21 RTCConfiguration() {} | |
| 22 virtual ~RTCConfiguration() {} | |
| 23 | |
| 24 virtual void AddIceServer( | |
| 25 std::string const& uri, | |
| 26 std::string const& username, | |
| 27 std::string const& credential) = 0; | |
| 28 | |
| 29 virtual Impl const& impl() const = 0; | |
|
mnaganov (inactive)
2014/11/10 18:10:26
Shouldn't it be "const& Impl" instead?
SeRya
2014/11/11 08:08:19
Checked in the styleguide. It requires "const Type
| |
| 30 | |
| 31 static scoped_ptr<RTCConfiguration> CreateInstance(); | |
| 32 | |
| 33 private: | |
|
mnaganov (inactive)
2014/11/10 18:10:26
Bad indentation.
SeRya
2014/11/11 08:08:19
Done.
| |
| 34 DISALLOW_COPY_AND_ASSIGN(RTCConfiguration); | |
| 35 }; | |
| 36 | |
| 37 } // namespace devtools_bridge | |
| 38 | |
| 39 #endif // COMPONENTS_DEVTOOLS_BRIDGE_RTC_CONFIGURATION_H_ | |
| OLD | NEW |