Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1948)

Issue 716413005: Do the early return when role is different than UnknownRole (Closed)

Created:
6 years ago by k.czech
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Do the early return when role is different than UnknownRole We do not need to call ariaRoleAttribute() to check whether current role is different than UnknownRole. Just check m_ariaRole instead. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
k.czech
6 years ago (2014-11-24 15:35:41 UTC) #1
dmazzoni
lgtm
6 years ago (2014-11-24 17:19:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716413005/1
6 years ago (2014-11-24 17:20:31 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-24 19:28:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185900

Powered by Google App Engine
This is Rietveld 408576698