Issue 716413005: Do the early return when role is different than UnknownRole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 716413005: Do the early return when role is different than UnknownRole (Closed)

Created:
6 years ago by k.czech

Modified:
6 years ago

Reviewers:
dmazzoni

CC:
dmazzoni

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Do the early return when role is different than UnknownRole We do not need to call ariaRoleAttribute() to check whether current role is different than UnknownRole. Just check m_ariaRole instead. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185900

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	Source/modules/accessibility/AXNodeObject.cpp	View		1 chunk	+2 lines, -5 lines	0 comments	Download
	M	Source/modules/accessibility/AXRenderObject.cpp	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716413005/1

6 years ago (2014-11-24 17:20:31 UTC) #5

commit-bot: I haz the power

6 years ago (2014-11-24 19:28:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185900

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages