Source/modules/accessibility/AXNodeObject.cpp - Issue 716413005: Do the early return when role is different than UnknownRole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 716413005: Do the early return when role is different than UnknownRole (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index 269e81a68ac453d64ecf20362e459ff6bc229a88..b92f040541fae9bcbf99548e5453a3642f5673a0 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -182,11 +182,8 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()

if (!node())

return UnknownRole;

- m_ariaRole = determineAriaRoleAttribute();

- AccessibilityRole ariaRole = ariaRoleAttribute();

- if (ariaRole != UnknownRole)

- return ariaRole;

+ if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole)

+ return m_ariaRole;

if (node()->isLink())

return LinkRole;

« no previous file with comments | « no previous file | Source/modules/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »