Use uint16 for port numbers, chrome/ edition

Use uint16 for port numbers, chrome/ edition

This is a piece of a larger CL, split up to avoid overwhelming reviewers. The
entire CL can be viewed at https://codereview.chromium.org/655063002/ .
The intent is to get each piece reviewed separately, then finally land the large
CL after all parts have been approved.

BUG=81439
TEST=none

[Peter Kasting, 2014-11-12 23:49:20]

pkasting@chromium.org changed reviewers:
+ jhawkins@chromium.org

[Peter Kasting, 2014-11-12 23:54:00]

This is not an independent CL; please see the description for a link to the full
context including brief rationale.

To minimize the chance of problems, after getting green try runs on the large
change, I manually reviewed each smaller CL and added comments where helpful.

https://codereview.chromium.org/716223002/diff/20001/chrome/test/chromedriver...
File chrome/test/chromedriver/net/port_server.cc (right):

https://codereview.chromium.org/716223002/diff/20001/chrome/test/chromedriver...
chrome/test/chromedriver/net/port_server.cc:125: new_port < 0 || new_port >
65535)
The old code probably should have had these checks already.

https://codereview.chromium.org/716223002/diff/20001/chrome/test/chromedriver...
chrome/test/chromedriver/net/port_server.cc:149: for (uint32 try_port = start;
try_port != start || !wrapped; ++try_port) {
Using a uint16 wouldn't work correctly if max_port_ was 65535.

https://codereview.chromium.org/716223002/diff/20001/chrome/test/chromedriver...
File chrome/test/chromedriver/server/chromedriver_server.cc (right):

https://codereview.chromium.org/716223002/diff/20001/chrome/test/chromedriver...
chrome/test/chromedriver/server/chromedriver_server.cc:259: cmd_line_port < 0 ||
cmd_line_port > 65535) {
Again, the old code probably should have had these checks already.

[James Hawkins, 2014-11-13 19:00:28]

lgtm