Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/app_background_page_apitest.cc

Issue 716223002: Use uint16 for port numbers, chrome/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/browser/net/dns_probe_service.cc » ('j') | chrome/test/chromedriver/net/port_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/app_background_page_apitest.cc
diff --git a/chrome/browser/extensions/app_background_page_apitest.cc b/chrome/browser/extensions/app_background_page_apitest.cc
index 2059f81394ad7e1c3561122d7e0e954e133e6614..c0bbe0779320c2d6bcae882b1d9d7961d7adccb0 100644
--- a/chrome/browser/extensions/app_background_page_apitest.cc
+++ b/chrome/browser/extensions/app_background_page_apitest.cc
@@ -226,7 +226,7 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, MAYBE_Basic) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" },"
" \"permissions\": [\"background\"]"
@@ -259,7 +259,7 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, DISABLED_LacksPermission) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" }"
"}",
@@ -287,12 +287,12 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, ManifestBackgroundPage) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" },"
" \"permissions\": [\"background\"],"
" \"background\": {"
- " \"page\": \"http://a.com:%d/test.html\""
+ " \"page\": \"http://a.com:%u/test.html\""
" }"
"}",
embedded_test_server()->port(),
@@ -340,7 +340,7 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, NoJsBackgroundPage) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/test.html\""
+ " \"web_url\": \"http://a.com:%u/test.html\""
" }"
" },"
" \"permissions\": [\"background\"],"
@@ -384,12 +384,12 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, NoJsManifestBackgroundPage) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" },"
" \"permissions\": [\"background\"],"
" \"background\": {"
- " \"page\": \"http://a.com:%d/bg.html\","
+ " \"page\": \"http://a.com:%u/bg.html\","
" \"allow_js_access\": false"
" }"
"}",
@@ -424,7 +424,7 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, OpenTwoBackgroundPages) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" },"
" \"permissions\": [\"background\"]"
@@ -453,11 +453,11 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, OpenTwoPagesWithManifest) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" },"
" \"background\": {"
- " \"page\": \"http://a.com:%d/bg.html\""
+ " \"page\": \"http://a.com:%u/bg.html\""
" },"
" \"permissions\": [\"background\"]"
"}",
@@ -488,10 +488,10 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, DISABLED_OpenPopupFromBGPage) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" },"
- " \"background\": { \"page\": \"http://a.com:%d/extensions/api_test/"
+ " \"background\": { \"page\": \"http://a.com:%u/extensions/api_test/"
"app_background_page/bg_open/bg_open_bg.html\" },"
" \"permissions\": [\"background\"]"
"}",
@@ -518,7 +518,7 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, DISABLED_OpenThenClose) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" },"
" \"permissions\": [\"background\"]"
@@ -564,12 +564,12 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, UnloadExtensionWhileHidden) {
" \"http://a.com/\""
" ],"
" \"launch\": {"
- " \"web_url\": \"http://a.com:%d/\""
+ " \"web_url\": \"http://a.com:%u/\""
" }"
" },"
" \"permissions\": [\"background\"],"
" \"background\": {"
- " \"page\": \"http://a.com:%d/test.html\""
+ " \"page\": \"http://a.com:%u/test.html\""
" }"
"}",
embedded_test_server()->port(),
« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/browser/net/dns_probe_service.cc » ('j') | chrome/test/chromedriver/net/port_server.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698