Issue 716213002: Remove 'paginated line width' from RootInlineBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 716213002: Remove 'paginated line width' from RootInlineBox. (Closed)

Created:
6 years, 1 month ago by mstensho (USE GERRIT)

Modified:
6 years, 1 month ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Remove 'paginated line width' from RootInlineBox. It was set but never used. Probably a relic from CSS regions support. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185233

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -8 lines)			Patch
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RootInlineBox.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RootInlineBox.cpp	View	3 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

mstensho (USE GERRIT)

So, in light of https://codereview.chromium.org/715973004/ , the lazy allocation would now have saved us nothing. ...

6 years, 1 month ago (2014-11-12 17:46:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716213002/1

6 years, 1 month ago (2014-11-12 17:50:38 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-12 18:58:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 185233