Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 715973004: Remove FragementationData lazyness (Closed)

Created:
6 years, 1 month ago by leviw_travelin_and_unemployed
Modified:
6 years, 1 month ago
Reviewers:
chrishtr, pdr., eae
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove FragementationData lazyness Having fragmentation data be lazy on RootInlineBox only saves us a single int (due to the pointer and the fact that we have room to pack its bool into InlineFlowBox's bitfields), and the allocation overhead was large enough it appeared on performance tests (see bug). BUG=313700 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185170

Patch Set 1 #

Patch Set 2 : Remove RenderBlockFlow change #

Patch Set 3 : Fix compile error #

Patch Set 4 : Fix moar compiler bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -35 lines) Patch
M Source/core/rendering/InlineFlowBox.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/rendering/RootInlineBox.h View 4 chunks +5 lines, -33 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
leviw_travelin_and_unemployed
6 years, 1 month ago (2014-11-12 00:22:32 UTC) #2
eae
LGTM
6 years, 1 month ago (2014-11-12 00:26:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715973004/40001
6 years, 1 month ago (2014-11-12 00:28:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/16494) linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/32502) linux_blink_rel ...
6 years, 1 month ago (2014-11-12 00:40:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715973004/60001
6 years, 1 month ago (2014-11-12 01:21:54 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 02:30:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 185170

Powered by Google App Engine
This is Rietveld 408576698