Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 716123002: [content/browser/download] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, yoshiki+watch_chromium.org, jam, rginda+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[content/browser/download] Convert VLOGs to DVLOGs BUG=101424 Committed: https://crrev.com/d9a287445f94d8db77ec6492ddb5d7c4d9a56838 Cr-Commit-Position: refs/heads/master@{#303855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -49 lines) Patch
M content/browser/download/download_item_impl.cc View 17 chunks +28 lines, -27 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/download/file_metadata_unittest_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/save_file_manager.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/download/save_package.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-12 13:20:38 UTC) #2
Randy Smith (Not in Mondays)
lgtm
6 years, 1 month ago (2014-11-12 17:21:03 UTC) #3
anujsharma
On 2014/11/12 17:21:03, rdsmith wrote: > lgtm Thanks rdsmith for lgtm.
6 years, 1 month ago (2014-11-12 17:31:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716123002/1
6 years, 1 month ago (2014-11-12 17:32:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 18:27:30 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 18:28:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9a287445f94d8db77ec6492ddb5d7c4d9a56838
Cr-Commit-Position: refs/heads/master@{#303855}

Powered by Google App Engine
This is Rietveld 408576698