content/browser/download/save_file_manager.cc - Issue 716123002: [content/browser/download] Convert VLOGs to DVLOGs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_file_manager.cc

Issue 716123002: [content/browser/download] Convert VLOGs to DVLOGs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/save_file_manager.cc

diff --git a/content/browser/download/save_file_manager.cc b/content/browser/download/save_file_manager.cc

index e9c03f484ff62179d63389d7ec5645b05104f68d..f96230ee3e5cff2adf6057de1cb38e5a52cbf780 100644

--- a/content/browser/download/save_file_manager.cc

+++ b/content/browser/download/save_file_manager.cc

@@ -263,10 +263,10 @@ void SaveFileManager::SaveFinished(int save_id,

const GURL& save_url,

int render_process_id,

bool is_success) {

- VLOG(20) << " " << __FUNCTION__ << "()"

- << " save_id = " << save_id

- << " save_url = \"" << save_url.spec() << "\""

- << " is_success = " << is_success;

+ DVLOG(20) << " " << __FUNCTION__ << "()"

+ << " save_id = " << save_id

+ << " save_url = \"" << save_url.spec() << "\""

+ << " is_success = " << is_success;

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

SaveFileMap::iterator it = save_file_map_.find(save_id);

if (it != save_file_map_.end()) {

@@ -278,8 +278,8 @@ void SaveFileManager::SaveFinished(int save_id,

// TODO(rdsmith): Fix this logic and put the DCHECK below back in.

// DCHECK(save_file->InProgress());

- VLOG(20) << " " << __FUNCTION__ << "()"

- << " save_file = " << save_file->DebugString();

+ DVLOG(20) << " " << __FUNCTION__ << "()"

+ << " save_file = " << save_file->DebugString();

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

base::Bind(&SaveFileManager::OnSaveFinished, this, save_id,