Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 716053003: [DevTools] Move PNG encoding from UI to worker thread. (Closed)

Created:
6 years, 1 month ago by vkuzkokov
Modified:
6 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move PNG encoding from UI to worker thread. BUG=397107 Committed: https://crrev.com/6730701ccdc091a34271d51dc3ee9d1f5fc7142a Cr-Commit-Position: refs/heads/master@{#305033}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : Rebased #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -40 lines) Patch
M content/browser/devtools/protocol/page_handler.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 2 3 6 chunks +51 lines, -37 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
vkuzkokov
6 years, 1 month ago (2014-11-17 13:50:49 UTC) #2
dgozman
Have you measured the impact of this change? https://codereview.chromium.org/716053003/diff/1/content/browser/devtools/protocol/page_handler.cc File content/browser/devtools/protocol/page_handler.cc (right): https://codereview.chromium.org/716053003/diff/1/content/browser/devtools/protocol/page_handler.cc#newcode539 content/browser/devtools/protocol/page_handler.cc:539: base::WorkerPool::PostTask( ...
6 years, 1 month ago (2014-11-17 14:03:59 UTC) #3
vkuzkokov
https://codereview.chromium.org/716053003/diff/1/content/browser/devtools/protocol/page_handler.cc File content/browser/devtools/protocol/page_handler.cc (right): https://codereview.chromium.org/716053003/diff/1/content/browser/devtools/protocol/page_handler.cc#newcode539 content/browser/devtools/protocol/page_handler.cc:539: base::WorkerPool::PostTask( On 2014/11/17 14:03:59, dgozman wrote: > Maybe use ...
6 years, 1 month ago (2014-11-17 14:47:47 UTC) #4
dgozman
lgtm https://codereview.chromium.org/716053003/diff/40001/content/browser/devtools/protocol/page_handler.cc File content/browser/devtools/protocol/page_handler.cc (right): https://codereview.chromium.org/716053003/diff/40001/content/browser/devtools/protocol/page_handler.cc#newcode486 content/browser/devtools/protocol/page_handler.cc:486: static std::string EncodeScreencastFrame(const SkBitmap& bitmap, Let's move to ...
6 years, 1 month ago (2014-11-20 14:23:05 UTC) #5
vkuzkokov
https://codereview.chromium.org/716053003/diff/40001/content/browser/devtools/protocol/page_handler.cc File content/browser/devtools/protocol/page_handler.cc (right): https://codereview.chromium.org/716053003/diff/40001/content/browser/devtools/protocol/page_handler.cc#newcode486 content/browser/devtools/protocol/page_handler.cc:486: static std::string EncodeScreencastFrame(const SkBitmap& bitmap, On 2014/11/20 14:23:05, dgozman ...
6 years, 1 month ago (2014-11-20 14:55:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716053003/60001
6 years, 1 month ago (2014-11-20 14:55:56 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-20 17:53:05 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 17:54:02 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/6730701ccdc091a34271d51dc3ee9d1f5fc7142a
Cr-Commit-Position: refs/heads/master@{#305033}

Powered by Google App Engine
This is Rietveld 408576698