[DevTools] Move PNG encoding from UI to worker thread.

content/browser/devtools/protocol/page_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/protocol/page_handler.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/threading/worker_pool.h"
 #include "content/browser/devtools/protocol/color_picker.h"
 #include "content/browser/devtools/protocol/usage_and_quota_query.h"
 #include "content/browser/geolocation/geolocation_service_context.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/javascript_dialog_manager.h"
 #include "content/public/browser/navigation_controller.h"
@@ skipping 446 matching lines @@
   gfx::Size snapshot_size_dip(gfx::ToRoundedSize(
       gfx::ScaleSize(viewport_size_dip, scale)));
 
   if (snapshot_size_dip.width() > 0 && snapshot_size_dip.height() > 0) {
     gfx::Rect viewport_bounds_dip(gfx::ToRoundedSize(viewport_size_dip));
     view->CopyFromCompositingSurface(
         viewport_bounds_dip,
         snapshot_size_dip,
         base::Bind(&PageHandler::ScreencastFrameCaptured,
                    weak_factory_.GetWeakPtr(),
-                   screencast_format_,
-                   screencast_quality_,
                    last_compositor_frame_metadata_),
         kN32_SkColorType);
   }
 }
 
-void PageHandler::ScreencastFrameCaptured(
+static void EncodeScreencastFrame(
+    const SkBitmap& bitmap,
     const std::string& format,
     int quality,
-    const cc::CompositorFrameMetadata& metadata,
-    const SkBitmap& bitmap,
-    ReadbackResponse response) {
-  if (response != READBACK_SUCCESS) {
-    if (capture_retry_count_) {
-      --capture_retry_count_;
-      base::MessageLoop::current()->PostDelayedTask(
-          FROM_HERE,
-          base::Bind(&PageHandler::InnerSwapCompositorFrame,
-                     weak_factory_.GetWeakPtr()),
-          base::TimeDelta::FromMilliseconds(kFrameRateThresholdMs));
-    }
-    return;
-  }
-
+    const base::Callback<void(const std::string&)> callback) {
   std::vector<unsigned char> data;
   SkAutoLockPixels lock_image(bitmap);
   bool encoded;
   if (format == kPng) {
     encoded = gfx::PNGCodec::Encode(
         reinterpret_cast<unsigned char*>(bitmap.getAddr32(0, 0)),
         gfx::PNGCodec::FORMAT_SkBitmap,
         gfx::Size(bitmap.width(), bitmap.height()),
         bitmap.width() * bitmap.bytesPerPixel(),
         false, std::vector<gfx::PNGCodec::Comment>(), &data);
@@ skipping 10 matching lines @@
   }
 
   if (!encoded)
     return;
 
   std::string base_64_data;
   base::Base64Encode(
       base::StringPiece(reinterpret_cast<char*>(&data[0]), data.size()),
       &base_64_data);
 
+  BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+                          base::Bind(callback, base_64_data));
+}
+
+void PageHandler::ScreencastFrameCaptured(
+    const cc::CompositorFrameMetadata& metadata,
+    const SkBitmap& bitmap,
+    ReadbackResponse response) {
+  if (response != READBACK_SUCCESS) {
+    if (capture_retry_count_) {
+      --capture_retry_count_;
+      base::MessageLoop::current()->PostDelayedTask(
+          FROM_HERE,
+          base::Bind(&PageHandler::InnerSwapCompositorFrame,
+                     weak_factory_.GetWeakPtr()),
+          base::TimeDelta::FromMilliseconds(kFrameRateThresholdMs));
+    }
+    return;
+  }
+  base::WorkerPool::PostTask(

[dgozman, 2014/11/17 14:03:59]

Maybe use PostTaskAndReply?

[vkuzkokov, 2014/11/17 14:47:47]

PostTaskAndReplyWithResult. Done.

+      FROM_HERE,
+      base::Bind(&EncodeScreencastFrame,
+                 bitmap,
+                 screencast_format_,

[dgozman, 2014/11/17 14:03:59]

We passed these as params for the case when e.g. format changed with next
protocol call.

[vkuzkokov, 2014/11/17 14:47:47]

This way we use more recent settings for format and quality.

+                 screencast_quality_,
+                 base::Bind(&PageHandler::ScreencastFrameEncoded,
+                            weak_factory_.GetWeakPtr(), metadata)),
+      true);
+}
+
+void PageHandler::ScreencastFrameEncoded(
+    const cc::CompositorFrameMetadata& metadata,
+    const std::string& data) {
   // Consider metadata empty in case it has no device scale factor.
   if (metadata.device_scale_factor == 0 || !host_)
     return;
 
   RenderWidgetHostViewBase* view = static_cast<RenderWidgetHostViewBase*>(
       host_->GetView());
   if (!view)
     return;
 
   gfx::SizeF viewport_size_dip = gfx::ScaleSize(
@@ skipping 13 matching lines @@
           ->set_device_width(screen_size_dip.width())
           ->set_device_height(screen_size_dip.height())
           ->set_scroll_offset_x(metadata.root_scroll_offset.x())
           ->set_scroll_offset_y(metadata.root_scroll_offset.y())
           ->set_viewport(dom::Rect::Create()
               ->set_x(metadata.root_scroll_offset.x())
               ->set_y(metadata.root_scroll_offset.y())
               ->set_width(metadata.scrollable_viewport_size.width())
               ->set_height(metadata.scrollable_viewport_size.height()));
   client_->ScreencastFrame(ScreencastFrameParams::Create()
-      ->set_data(base_64_data)
+      ->set_data(data)
       ->set_metadata(param_metadata));
 }
 
 void PageHandler::ScreenshotCaptured(
     scoped_refptr<DevToolsProtocol::Command> command,
     const unsigned char* png_data,
     size_t png_size) {
   if (!png_data || !png_size) {
     client_->SendInternalErrorResponse(command,
                                        "Unable to capture screenshot");
@@ skipping 17 matching lines @@
 
 void PageHandler::QueryUsageAndQuotaCompleted(
     scoped_refptr<DevToolsProtocol::Command> command,
     scoped_refptr<QueryUsageAndQuotaResponse> response_data) {
   client_->SendQueryUsageAndQuotaResponse(command, response_data);
 }
 
 }  // namespace page
 }  // namespace devtools
 }  // namespace content