Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 715583007: Various webview cleanup. (Closed)

Created:
6 years, 1 month ago by paulmeyer
Modified:
6 years, 1 month ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Various webview cleanup. ********** - Optimized onSizeChanged(). - Got rid of throwing errors. - Removed some unused or unnecessary helper functions. - Removed some other unnecessary code. - executeScript() and insertCSS() now share their code (since it was nearly identical in the first place). BUG=431002 Committed: https://crrev.com/848f1ed0482838d44ffd0bbbd3b8db0e5b6362c6 Cr-Commit-Position: refs/heads/master@{#303713}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : Fix. #

Patch Set 4 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -113 lines) Patch
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 chunk +6 lines, -7 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view.js View 1 2 3 10 chunks +33 lines, -84 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_events.js View 1 2 3 4 chunks +3 lines, -7 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_experimental.js View 1 chunk +0 lines, -8 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 1 2 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
paulmeyer
+fsamuel@
6 years, 1 month ago (2014-11-10 21:55:25 UTC) #2
Fady Samuel
Horray for negative net line count! lgtm! https://codereview.chromium.org/715583007/diff/1/extensions/renderer/resources/guest_view/web_view.js File extensions/renderer/resources/guest_view/web_view.js (right): https://codereview.chromium.org/715583007/diff/1/extensions/renderer/resources/guest_view/web_view.js#newcode178 extensions/renderer/resources/guest_view/web_view.js:178: } minWidth ...
6 years, 1 month ago (2014-11-11 00:04:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715583007/20001
6 years, 1 month ago (2014-11-11 00:31:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/9593)
6 years, 1 month ago (2014-11-11 02:19:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715583007/40001
6 years, 1 month ago (2014-11-11 16:43:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/4687)
6 years, 1 month ago (2014-11-11 17:40:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715583007/60001
6 years, 1 month ago (2014-11-11 18:57:31 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-11 20:37:45 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 20:39:10 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/848f1ed0482838d44ffd0bbbd3b8db0e5b6362c6
Cr-Commit-Position: refs/heads/master@{#303713}

Powered by Google App Engine
This is Rietveld 408576698