Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: extensions/renderer/resources/guest_view/web_view_events.js

Issue 715583007: Various webview cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/web_view_events.js
diff --git a/extensions/renderer/resources/guest_view/web_view_events.js b/extensions/renderer/resources/guest_view/web_view_events.js
index 73249c4227f9ead204ccc3b88dfa4c7d31b056f2..1f05be667861565bdc896cb669736022b4886a17 100644
--- a/extensions/renderer/resources/guest_view/web_view_events.js
+++ b/extensions/renderer/resources/guest_view/web_view_events.js
@@ -269,10 +269,6 @@ WebViewEvents.prototype.setupWebRequestEvents = function() {
};
WebViewEvents.prototype.getEvents = function() {
- var experimentalEvents = this.webViewImpl.maybeGetExperimentalEvents();
- for (var eventName in experimentalEvents) {
- WEB_VIEW_EVENTS[eventName] = experimentalEvents[eventName];
- }
var chromeEvents = this.webViewImpl.maybeGetChromeWebViewEvents();
for (var eventName in chromeEvents) {
WEB_VIEW_EVENTS[eventName] = chromeEvents[eventName];
@@ -327,7 +323,7 @@ WebViewEvents.prototype.handleDialogEvent = function(event, webViewEvent) {
};
var getGuestInstanceId = function() {
- return this.webViewImpl.getGuestInstanceId();
+ return this.webViewImpl.guestInstanceId;
}.bind(this);
var dialog = {
@@ -414,7 +410,7 @@ WebViewEvents.prototype.handleNewWindowEvent = function(event, webViewEvent) {
var requestId = event.requestId;
var actionTaken = false;
var getGuestInstanceId = function() {
- return this.webViewImpl.getGuestInstanceId();
+ return this.webViewImpl.guestInstanceId;
}.bind(this);
var validateCall = function() {
@@ -530,7 +526,7 @@ WebViewEvents.prototype.handlePermissionEvent =
var requestId = event.requestId;
var getGuestInstanceId = function() {
- return this.webViewImpl.getGuestInstanceId();
+ return this.webViewImpl.guestInstanceId;
}.bind(this);
if (this.permissionTypes.indexOf(event.permission) < 0) {

Powered by Google App Engine
This is Rietveld 408576698