Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 715413002: More cleanup: streamline paths and bitmaps. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

More cleanup: streamline paths and bitmaps. SkBitmapHeap is still used---now exclusively---by pipe. BUG=skia: Committed: https://skia.googlesource.com/skia/+/71a236370792416b367a7d2d6b8e471b06b331cd

Patch Set 1 #

Patch Set 2 : size check #

Total comments: 2

Patch Set 3 : no leaks #

Patch Set 4 : newline #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -232 lines) Patch
M gyp/core.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
D src/core/SkPathHeap.h View 1 chunk +0 lines, -76 lines 0 comments Download
D src/core/SkPathHeap.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
M src/core/SkPictureData.h View 3 chunks +3 lines, -13 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 2 3 6 chunks +18 lines, -14 lines 0 comments Download
M src/core/SkPictureRecord.h View 3 chunks +3 lines, -10 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 3 chunks +15 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mtklein
6 years, 1 month ago (2014-11-12 17:57:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715413002/1
6 years, 1 month ago (2014-11-12 18:01:46 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-12 18:01:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715413002/20001
6 years, 1 month ago (2014-11-12 18:05:06 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-12 18:05:08 UTC) #9
robertphillips
lgtm + nit https://codereview.chromium.org/715413002/diff/20001/src/core/SkPictureData.cpp File src/core/SkPictureData.cpp (right): https://codereview.chromium.org/715413002/diff/20001/src/core/SkPictureData.cpp#newcode440 src/core/SkPictureData.cpp:440: } break; newline before the if ...
6 years, 1 month ago (2014-11-12 18:12:55 UTC) #11
mtklein
https://codereview.chromium.org/715413002/diff/20001/src/core/SkPictureData.cpp File src/core/SkPictureData.cpp (right): https://codereview.chromium.org/715413002/diff/20001/src/core/SkPictureData.cpp#newcode440 src/core/SkPictureData.cpp:440: } break; On 2014/11/12 18:12:55, robertphillips wrote: > newline ...
6 years, 1 month ago (2014-11-12 18:15:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715413002/80001
6 years, 1 month ago (2014-11-12 18:16:26 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 18:25:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/71a236370792416b367a7d2d6b8e471b06b331cd

Powered by Google App Engine
This is Rietveld 408576698