Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 715273002: [content/gpu] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[content/gpu] Convert VLOGs to DVLOGs BUG=101424 Committed: https://crrev.com/98e81a1a63400604ece72cf808eeb43b97a5610e Cr-Commit-Position: refs/heads/master@{#304176}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M content/gpu/gpu_child_thread.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-12 13:21:00 UTC) #2
piman
https://codereview.chromium.org/715273002/diff/1/content/gpu/gpu_child_thread.cc File content/gpu/gpu_child_thread.cc (right): https://codereview.chromium.org/715273002/diff/1/content/gpu/gpu_child_thread.cc#newcode80 content/gpu/gpu_child_thread.cc:80: DVLOG(1) << "gfx::GLSurface::InitializeOneOff failed"; This is important info we ...
6 years, 1 month ago (2014-11-14 00:23:25 UTC) #3
anujsharma
On 2014/11/14 00:23:25, piman (Very slow to review) wrote: > https://codereview.chromium.org/715273002/diff/1/content/gpu/gpu_child_thread.cc > File content/gpu/gpu_child_thread.cc (right): ...
6 years, 1 month ago (2014-11-14 03:26:48 UTC) #4
piman
lgtm
6 years, 1 month ago (2014-11-14 04:00:44 UTC) #5
anujsharma
On 2014/11/14 04:00:44, piman (Very slow to review) wrote: > lgtm Thanks piman for lgtm.
6 years, 1 month ago (2014-11-14 04:04:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715273002/20001
6 years, 1 month ago (2014-11-14 04:04:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-14 04:54:28 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 04:55:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98e81a1a63400604ece72cf808eeb43b97a5610e
Cr-Commit-Position: refs/heads/master@{#304176}

Powered by Google App Engine
This is Rietveld 408576698