Issue 715123002: Rename sky::TestObserver to sky::TestHarness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 715123002: Rename sky::TestObserver to sky::TestHarness (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn, ojan

CC:
esprehn, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Rename sky::TestObserver to sky::TestHarness This CL prepares us to add event dispatching to this interface, which is more than just observation. R=esprehn@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/129a525e38ed09d3644371c008c508719d10e991

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -90 lines)			Patch
M	sky/tools/tester/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sky/tools/tester/DEPS	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	sky/tools/tester/test_harness_impl.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A +	sky/tools/tester/test_harness_impl.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
D	sky/tools/tester/test_observer_impl.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	sky/tools/tester/test_observer_impl.cc	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	sky/tools/tester/test_runner.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/tools/tester/test_runner.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/viewer/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/internals.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/viewer/internals.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	sky/viewer/services/test_harness.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
D	sky/viewer/test_observer.mojom	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

6 years, 1 month ago (2014-11-12 00:43:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
129a525e38ed09d3644371c008c508719d10e991 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages