Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: sky/tools/tester/test_harness_impl.cc

Issue 715123002: Rename sky::TestObserver to sky::TestHarness (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/tools/tester/test_harness_impl.h ('k') | sky/tools/tester/test_observer_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/tools/tester/test_observer_impl.h" 5 #include "sky/tools/tester/test_harness_impl.h"
6 6
7 #include "sky/tools/tester/test_runner.h" 7 #include "sky/tools/tester/test_runner.h"
8 8
9 namespace sky { 9 namespace sky {
10 namespace tester { 10 namespace tester {
11 11
12 TestObserverImpl::TestObserverImpl(TestRunner* test_runner) 12 TestHarnessImpl::TestHarnessImpl(TestRunner* test_runner)
13 : test_runner_(test_runner->GetWeakPtr()) { 13 : test_runner_(test_runner->GetWeakPtr()) {
14 // FIXME: This is technically when the V8 context gets created and 14 // FIXME: This is technically when the V8 context gets created and
15 // not when the test is started. An error before we instantiated 15 // not when the test is started. An error before we instantiated
16 // the V8 context would show up before the #BEGIN line for this test. 16 // the V8 context would show up before the #BEGIN line for this test.
17 test_runner->OnTestStart(); 17 test_runner->OnTestStart();
18 } 18 }
19 19
20 TestObserverImpl::~TestObserverImpl() { 20 TestHarnessImpl::~TestHarnessImpl() {
21 } 21 }
22 22
23 void TestObserverImpl::OnTestComplete(const mojo::String& test_result) { 23 void TestHarnessImpl::OnTestComplete(const mojo::String& test_result) {
24 if (test_runner_) 24 if (test_runner_)
25 test_runner_->OnTestComplete(test_result); 25 test_runner_->OnTestComplete(test_result);
26 } 26 }
27 27
28 } // namespace tester 28 } // namespace tester
29 } // namespace sky 29 } // namespace sky
OLDNEW
« no previous file with comments | « sky/tools/tester/test_harness_impl.h ('k') | sky/tools/tester/test_observer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698