Issue 715093003: Clang incorrectly thinks this typedef is unused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 715093003: Clang incorrectly thinks this typedef is unused. (Closed)

Created:
6 years, 1 month ago by mtklein_C

Modified:
6 years, 1 month ago

Reviewers:
tfarina, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Clang incorrectly thinks this typedef is unused. BUG=skia:3059 Committed: https://skia.googlesource.com/skia/+/ad8aa1dcf36d64ddf849b914281713b901a01f49

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	tests/RecordDrawTest.cpp	View		2 chunks	+1 line, -3 lines	1 comment	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715093003/1

6 years, 1 month ago (2014-11-12 02:44:05 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ad8aa1dcf36d64ddf849b914281713b901a01f49

6 years, 1 month ago (2014-11-12 02:52:07 UTC) #5

tfarina

6 years, 1 month ago (2014-11-12 11:12:02 UTC) #7

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/715093003/diff/1/tests/RecordDrawTest.cpp
File tests/RecordDrawTest.cpp (right):

https://codereview.chromium.org/715093003/diff/1/tests/RecordDrawTest.cpp#new...
tests/RecordDrawTest.cpp:288: SkCanvasMock(int width, int height) :
SkCanvas(width, height) {
thanks, this was the way I was "fixing" it locally.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages