Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: tests/RecordDrawTest.cpp

Issue 715093003: Clang incorrectly thinks this typedef is unused. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/RecordDrawTest.cpp
diff --git a/tests/RecordDrawTest.cpp b/tests/RecordDrawTest.cpp
index 1dcd1331311f969901053e739d9b3dc2075e3bfe..2346655330793a293ea34f31b876a7f91f3c71ef 100644
--- a/tests/RecordDrawTest.cpp
+++ b/tests/RecordDrawTest.cpp
@@ -285,7 +285,7 @@ DEF_TEST(RecordDraw_SaveLayerBoundsAffectsClipBounds, r) {
DEF_TEST(RecordDraw_drawImage, r){
class SkCanvasMock : public SkCanvas {
public:
- SkCanvasMock(int width, int height) : INHERITED(width, height) {
+ SkCanvasMock(int width, int height) : SkCanvas(width, height) {
tfarina 2014/11/12 11:12:02 thanks, this was the way I was "fixing" it locally
this->resetTestValues();
}
virtual ~SkCanvasMock() {}
@@ -307,8 +307,6 @@ DEF_TEST(RecordDraw_drawImage, r){
bool fDrawImageCalled;
bool fDrawImageRectCalled;
- private:
- typedef SkCanvas INHERITED;
};
SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterPMColor(10, 10));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698